Enable single-window mode by default in projects #50680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are many issues with using multiple windows by default: - Taking screenshots of a specific window will not capture subwindows. This also applies when recording a video using tools such as OBS. - Subwindows may not behave correctly when fullscreen mode is enabled, especially if exclusive fullscreen is implemented in the future to decrease input lag on Windows. "Subwindows" is quite general here, and also refers to dropdown menus (e.g. those spawned by OptionButton) and Control tooltips. Therefore, it's safer to embed subwindows by default in projects. Multi-window mode remains the default in the editor.
|
Thank you! |
groud
approved these changes
Oct 20, 2021
|
I think we should change the default in the editor to also be single-window mode, not just in projects. |
|
I think for the editor multiple window support is a highly expected feature in 4.0 so we need to keep it enabled to actually see and fix the bugs. We can reassess later on if we really can't make it non buggy. But yes, for projects it makes sense to default to single-window mode. |
akien-mga
approved these changes
Oct 20, 2021
|
Thanks! |
This was referenced Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many issues with using multiple windows by default:
2dandviewportstretch modes. This is problematic for dropdown menus, as they will be tiny if using the2dorviewportstretch mode and playing at a higher resolution than the project's base resolution."Subwindows" is quite general here, and also refers to dropdown menus (e.g. those spawned by OptionButton) and Control tooltips.
Therefore, it's safer to embed subwindows by default in projects. This will also avoid various surprises when upgrading projects from
3.xto 4.0.Multi-window mode remains the default in the editor.
See discussion on the Godot Contributors Chat for more information.
There remains an open question: should we do this for custom Viewports by default?