[3.x] Allow checking for exact matches with Action events. #50874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May close godotengine/godot-proposals#2464 |
raulsntos
force-pushed
the
backport-44355
branch
from
28e496e
to
fcde297
Compare
|
Rebased on top of #50788 |
raulsntos
force-pushed
the
backport-44355
branch
from
fcde297
to
64cb437
Compare
|
Rebased on top of #50985 |
akien-mga
approved these changes
Jul 30, 2021
|
The class reference needs to be updated (make sure to keep the descriptions): https://github.com/godotengine/godot/pull/50874/checks?check_run_id=3200490164 The |
raulsntos
force-pushed
the
backport-44355
branch
from
08c5e54
to
6b38857
Compare
|
Could you squash the commits? Otherwise we'd been merging an intermediate commit that actually fails CI. |
Added additional param to action related methods to test for exactness.
If "p_exact_match" is true, then the action will only be "matched" if the provided input event *exactly* matches with the action event.
Before:
* Action Event = KEY_S
* Input Event = KEY_CONTROL + KEY_S
* Is Action Pressed = True
Now:
You can still do the above, however you can optionally check that the input is exactly what the action event is:
* Action Event = KEY_S
* Input Event = KEY_CONTROL + KEY_S
* p_exact_match = True
* Is Action Pressed = False
* If the Input Event was only KEY_S, then the result would be true.
Usage:
```gdscript
Input.is_action_pressed(action_name: String, exact_match: bool)
Input.is_action_pressed("my_action", true)
InputMap.event_is_action(p_event, "my_action", true)
func _input(event: InputEvent):
event.is_action_pressed("my_action", false, true) # false = "allow_echo", true = "exact_match"
event.is_action("my_action", true)
```
Co-authored-by: Eric M <[email protected]>
raulsntos
force-pushed
the
backport-44355
branch
from
6b38857
to
0e5c6e0
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #44355
Backport of #51064