-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebased Meson build system PR against current master #51153
Draft
jpakkane
wants to merge
105
commits into
godotengine:master
Choose a base branch
from
jpakkane:meson
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+43,982
−33,075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there has been no uptake for this and keeping this up to date takes a lot of effort, I'm going to stop working on this MR. Feel free to close this if you don't want to keep it around for posterity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #45093 rebased to work against the current master. It also has some minor correctness fixes. I only tested this on Linux where the build completes and can be run, but the end result has broken text (all Unicode replacement squares).
The build definitions work, but could use some TLC. For example the way it uses system libtheora is fairly complicated as opposed to using Meson subprojects and dependency management. Here is an equivalent build file for SDL Mixer that uses Vorbis. It would probably also make more sense to move from
config.py
scripts that you run to doing the configuration and header generation with Meson builtins.If there is genuine interest in getting this working, I can help with the work needed to get the rest of it working with equivalent or better level than the current SCons build.
Bugsquad edit: This closes godotengine/godot-proposals#1797.