Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebased Meson build system PR against current master #51153

Draft
wants to merge 105 commits into
base: master
Choose a base branch
from

Conversation

jpakkane
Copy link

@jpakkane jpakkane commented Aug 1, 2021

This is #45093 rebased to work against the current master. It also has some minor correctness fixes. I only tested this on Linux where the build completes and can be run, but the end result has broken text (all Unicode replacement squares).

The build definitions work, but could use some TLC. For example the way it uses system libtheora is fairly complicated as opposed to using Meson subprojects and dependency management. Here is an equivalent build file for SDL Mixer that uses Vorbis. It would probably also make more sense to move from config.py scripts that you run to doing the configuration and header generation with Meson builtins.

If there is genuine interest in getting this working, I can help with the work needed to get the rest of it working with equivalent or better level than the current SCons build.

Bugsquad edit: This closes godotengine/godot-proposals#1797.

@jpakkane jpakkane requested review from a team as code owners August 1, 2021 18:23
@qarmin qarmin removed request for a team August 1, 2021 18:53
@jpakkane
Copy link
Author

Since there has been no uptake for this and keeping this up to date takes a lot of effort, I'm going to stop working on this MR. Feel free to close this if you don't want to keep it around for posterity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from SCons to Meson to improve Godot's build performance