Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Add support for prompting the user to retain app data on uninstall. #51605

Merged

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Aug 13, 2021

As specified in the documentation:

When the user uninstalls an app, whether or not to show the user a prompt to keep the app's data. 

Supported on Android 10 and higher.

@akien-mga akien-mga merged commit 537077f into godotengine:3.x Aug 13, 2021
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the expose_fragile_user_data_config_3_x branch August 13, 2021 06:43
@akien-mga
Copy link
Member

Holding off 3.3 cherry-pick for now as the previous changes to this code (allowBackup, isGame) haven't been cherry-picked either. If we want them in 3.3.3 we should likely make a dedicated PR with all three and proper testing (I did a lot of mistakes when cherry-picking the isGame code initially for 3.x).

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Aug 13, 2021

There are features rather than bug fixes, so we can omit them from the 3.3 cherry-pick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants