Fixed crash executing TextEdit.new().set_draw_control_chars(true)

[vignesh-j-shetty]

Bug was because of uninitialized popup menu. So I put popup menu initialization in constructor itself.

Bugsquad edit: Fixes #51613.

[Paulb23]

This was removed from the constructor to increase performance. Instead, It should skip the menu update in set_draw_control_chars if it has not been created yet.

[vignesh-j-shetty]

This was removed from the constructor to increase performance. Instead, It should skip the menu update in set_draw_control_chars if it has not been created yet.

Okay I will do that.

[YeldhamDev]

Remember to squash your commits: https://docs.godotengine.org/en/stable/community/contributing/pr_workflow.html#the-interactive-rebase

[vignesh-j-shetty]

Remember to squash your commits: https://docs.godotengine.org/en/stable/community/contributing/pr_workflow.html#the-interactive-rebase

Is right what I have done? Bit inexperienced in git

[akien-mga]

Is right what I have done?

Not yet, as you can see there are 5 commits in this PR, when there should be only one.

You have to rebase to squash the commits into one (not merge), and force push to update the PR (again, without merging first, otherwise you're re-adding everything you just squashed).

I'll do it this time as in the current state it's not trivial to fix when not familiar with Git rebases.

Changes done.

[vignesh-j-shetty]

Is right what I have done?

Not yet, as you can see there are 5 commits in this PR, when there should be only one.

You have to rebase to squash the commits into one (not merge), and force push to update the PR (again, without merging first, otherwise you're re-adding everything you just squashed).

I'll do it this time as in the current state it's not trivial to fix when not familiar with Git rebases.

Thank you so much! Time to watch git tutorials :)

[akien-mga]

Thanks!