Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Skeleton3D regression when bones are not sorted from root to leaves #51798

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Fix Skeleton3D regression when bones are not sorted from root to leaves #51798

merged 1 commit into from
Aug 17, 2021

Conversation

pouleyKetchoupp
Copy link
Contributor

Tentative fix for missing bones when child bones are not sorted as expected.
Following up from #51368 (comment) - CC @TwistedTwigleg

For example, if the root comes last, all child bones are removed and the skeleton ends up with just the root.

@pouleyKetchoupp
Fix Skeleton3D regression when bones are not sorted from root to leaves
91fdf7c 
Tentative fix for missing bones when bones are not sorted as expected.
For example, if the root comes last, all child bones are removed and
the skeleton ends up with just the root.
@pouleyKetchoupp pouleyKetchoupp added this to the 4.0 milestone Aug 17, 2021
@pouleyKetchoupp pouleyKetchoupp requested a review from a team as a code owner August 17, 2021 15:38
@pouleyKetchoupp pouleyKetchoupp mentioned this pull request Aug 17, 2021
Merged
TwistedTwigleg
TwistedTwigleg approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@TwistedTwigleg TwistedTwigleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't think about that it could come in the wrong order. I guess all the files I worked with were already sorted so I never encountered it. My apologizes for not catching this in my testing and thanks for the quick fix 👍

@pouleyKetchoupp
Copy link
Contributor Author

No worries, corner cases always happen :)

@akien-mga akien-mga merged commit b463ac7 into godotengine:master Aug 17, 2021
@akien-mga
Copy link
Member

Thanks!

@pouleyKetchoupp pouleyKetchoupp deleted the fix-skeleton-child-bones branch August 17, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@TwistedTwigleg TwistedTwigleg TwistedTwigleg approved these changes

Assignees
No one assigned
Labels
bug regression topic:animation
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pouleyKetchoupp @akien-mga @TwistedTwigleg