Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Node's NOTIFICATION_PATH_CHANGED to NOTIFICATION_PATH_RENAMED #52387

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Rename Node's NOTIFICATION_PATH_CHANGED to NOTIFICATION_PATH_RENAMED #52387

merged 1 commit into from
Nov 25, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 3, 2021

The new name is less misleading, as the notification is only emitted when the node name (or one of its parents' names) is changed.

This closes godotengine/godot-proposals#1885.

@Calinou
Rename Node's NOTIFICATION_PATH_CHANGED to NOTIFICATION_PATH_RENAMED
879c37d 
The new name is less misleading, as the notification is only emitted
when the node name (or one of its parents' names) is changed.
@Calinou Calinou requested review from a team as code owners September 3, 2021 22:15
@Calinou Calinou added this to the 4.0 milestone Sep 3, 2021
mhilbrunner
mhilbrunner approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by today's PR meeting

Aside: we may want to rethink how/whether users can emit internal engine notifications eventually

@mhilbrunner mhilbrunner merged commit a6a2e0f into godotengine:master Nov 25, 2021
@mhilbrunner
Copy link
Member

Thanks!

@Calinou Calinou deleted the node-rename-path-changed-notification branch November 25, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@reduz reduz Awaiting requested review from reduz

Assignees
No one assigned
Labels
breaks compat enhancement topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Rename Node.NOTIFICATION_PATH_CHANGED to make it not misleading
2 participants
@Calinou @mhilbrunner