Fixed regression of skinning with skeleton #52462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
fixed-regression-of-skinning
branch
from
299a113
to
a2aa449
Compare
7 tasks
TokageItLab
force-pushed
the
fixed-regression-of-skinning
branch
from
a2aa449
to
48aa2d5
Compare
|
To be completely honest, we are discussing getting rid of bone rests, or having them only for gizmos, since you cant really expect to always have them available or have a single one. |
|
I guess for now lets merge, then we can discuss what to do with that |
reduz
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #51368 (comment). The calculation of global rest in skinning is wrong. This also broke the gizmo, so I fixed that as well.