Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project setting to change scene file casing #52597

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

Jummit
Copy link
Contributor

@Jummit Jummit commented Sep 12, 2021

Bugsquad edit: master version of #56909.

The documentation recommends file names to be in snake case, which is hard to implement because scene files take the name of the root node by default. This adds a project settings to change the default scene name to be either automatically generated, pascal case or snake case.

Should snake case be the default, like #47275 implemented?

Supersedes #47275

@Calinou
Copy link
Member

Calinou commented Sep 12, 2021

Should snake case be the default, like #47275 implemented?

Yes, as it sidesteps the case sensitivity issues that many users run into when exporting projects from Windows or macOS.

@Jummit
Copy link
Contributor Author

Jummit commented Sep 12, 2021

Should snake case be the default, like #47275 implemented?

Yes, as it sidesteps the case sensitivity issues that many users run into when exporting projects from Windows or macOS.

Done.

@fire
Copy link
Member

fire commented Dec 6, 2021

Saw this was on the https://github.com/orgs/godotengine/projects/16 board and wasn't ready to be merged as is. Can you rebase?

@Jummit
Copy link
Contributor Author

Jummit commented Dec 6, 2021

Saw this was on the github.com/orgs/godotengine/projects/16 board and wasn't ready to be merged as is. Can you rebase?

Done.

@Jummit
Copy link
Contributor Author

Jummit commented Dec 6, 2021

@fire
CI is finally finished!

@fire
Copy link
Member

fire commented Jan 16, 2022

While working on #56848.

I noticed there were special cases.

capitalize() before camelcase_to_underscore().
" " -> ""
"-" -> "_".

What are your thoughts?

@Jummit
Copy link
Contributor Author

Jummit commented Jan 17, 2022

The first one was already there, I added the second one as well.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in PR review meeting.

@akien-mga akien-mga merged commit 0a67b46 into godotengine:master Jan 18, 2022
@akien-mga
Copy link
Member

Thanks!

@rambda
Copy link

rambda commented Sep 22, 2022

It seems that "Save Branch As Scene" naming is not affected by "editor/scene/scene_naming" in 4.0.beta1.

@KoBeWi
Copy link
Member

KoBeWi commented Sep 22, 2022

It was fixed recently, will be available for beta2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants