Remove unused out_of_range_mode property from AudioStreamPlayer3D
#52774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Sep 17, 2021
|
You need to update the docs too. |
Calinou
force-pushed
the
audiostreamplayer3d-remove-out-of-range
branch
from
e564a3f
to
6701a39
Compare
|
You forgot to remove the |
The `out_of_range_mode` property is no longer used since audio mixing was moved out of the various AudioStreamPlayer nodes.
Calinou
force-pushed
the
audiostreamplayer3d-remove-out-of-range
branch
from
6701a39
to
973f52b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #52770 and #52773.
The
out_of_range_modeproperty is no longer used since audio mixing was moved out of the various AudioStreamPlayer nodes inmaster.