Improve error message when instantiating virtual class #53431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
cherrypick:3.x
akien-mga
approved these changes
Oct 5, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I just landed on this error:
Condition "!ti->creation_func" is true. Returned: __nullLooking for it, I only found godotengine/godot-docs#3460, which kind of helps, but is about a very different situation.
I ended up figuring that I can't inherit from CanvasItem which isn't something you'd think since Node2D and Control do inherit from it. I just added a message to clarify that situation:
"Class '" + String(p_class) + "' or its base class cannot be instantiated.Should make figuring out the issue easier.