Allow AudioStreamPlayer(2D) to provide pitch_scale on playback

[DeeJayLSP]

Fixes #53585

AudioServer forcibly gives the stream's pitch scale a value of 1 when calling start_playback_stream(). These changes ensure any pitch scale from AudioStreamPlayer and AudioStreamPlayer2D are the ones provided before calling play()

[ellenhp]

Could you use this function signature instead?

godot/servers/audio_server.h

Line 373 in ca11f8a

void start_playback_stream(Ref<AudioStreamPlayback> p_playback, Map<StringName, Vector<AudioFrame>> p_bus_volumes, float p_start_time = 0, float p_highshelf_gain = 0, float p_attenuation_cutoff_hz = 0, float p_pitch_scale = 1);

That way this will occur atomically. With this change the AudioServer could choose to start playing audio between one line and the next which could cause pitch to change abruptly several milliseconds after playback has started. Ears are really fast so that causes audible artifacts.

[DeeJayLSP]

I have added a pitch scale parameter to the convenience method, which then provides the value to the second start_playback_stream(). Tested and worked fine.

[ellenhp]

Good idea. I'll take a look in a few hours. That base method has a ridiculous number of parameters and given that we need pitch scale in multiple places that's definitely the smart thing to do. Oct 10, 2021 1:57:37 PM Douglas Leão ***@***.***>:

…

I have added a pitch scale parameter to the convenience method, which then provides the value to the second *start_playback_stream()*. Tested and worked fine. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub[#53641 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAOY266K2GCQO3IP2T3ZVTTUGH44DANCNFSM5FWURAKQ]. Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEIAAABCCAYAAADjVADoAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAnSURBVHic7cEBDQAAAMKg909tDwcUAAAAAAAAAAAAAAAAAAAAAPBjRFIAASHKmKkAAAAASUVORK5CYII=###24x24:true###][Tracking image][https://github.com/notifications/beacon/AAOY2662QT322L22TRUK3FTUGH44DA5CNFSM5FWURAK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHAAGV7Y.gif]

[DeeJayLSP]

Convenience change: instead of providing p_pitch_scale as the fourth parameter on the second start_playback_stream() it will provide as the second, so no empty parameters need to be provided by the first one. AudioStreamPlayer3D.cpp changed to fit. Tested with projects provided here and here, all functional.

[ellenhp]

Looks great. Thank you so much for fixing this one! I've had a hard time finding time to work on Godot lately.

[akien-mga]

Thanks!