Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase object snapping distances in the 3D editor #53727

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 12, 2021

  • Increase drag-and-drop snapping maximum distance to 50 units (from 10 units).
  • Increase Snap Object to Floor maximum height to 500 units (from 20 units).
  • Increase Snap Object to Floor negative margin to 1 unit (from 0.2 units).

See discussion starting from godotengine/godot-proposals#755 (comment).

As a future improvement, Snap Object to Floor could try snapping downwards from (max_distance / 2) (global Y coordinate) if no floor is found below the object. This way, the object doesn't need to be placed less than 1 unit below the floor to be correctly snapped back to the floor if there is nothing below. This can be done in a future PR.

Preview

Drag and drop snapping

drag-and-drop.mp4

Snap Object to Floor

Available in the 3D editor's View menu or by pressing Page Down.

snap-object-to-floor.mp4

- Increase drag-and-drop snapping to 50 units
  (from 10 units).
- Increase Snap Object to Floor maximum height to 500 units
  (from 20 units).
- Increase Snap Object to Floor negative margin to 1 unit
  (from 0.2 units).
@Calinou Calinou requested a review from a team as a code owner October 12, 2021 14:58
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:3d topic:editor usability labels Oct 12, 2021
@Calinou Calinou added this to the 4.0 milestone Oct 12, 2021
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature demonstrated improves usability. I always had trouble with activating this.

@akien-mga akien-mga merged commit 4d2c82e into godotengine:master Oct 13, 2021
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the 3d-editor-tweak-object-snap-distances branch October 13, 2021 13:43
@HardlineStudios
Copy link

Oh this looks great! Using grid maps isn't always an optimal way to build a level and so doing it the drag and drop way becomes quite time consuming without a feature like this.

@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants