-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove node_hrcr hack #54072
Remove node_hrcr hack #54072
Conversation
I think this is a very good idea and it may really improve the editor start up performance. I don't think the places where this was manually replaced are enough, though. From the top of my head, 3D importers (GLTF2, DAE and FBX) need to be checked because it is common that nodes can come without names there (GLTF2 is tricky because it can be used in run-time too, where this check would be unnecessary, but it would still be for importing), and I am unsure whether I am missing something else. This would be good to have other contributors involved to make 100% sure we are not forgetting anything. If you nag me over the week, I can give a general check of places where add_child is used to give you better feedback. |
@reduz I went over all usage of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me, I'll let @reduz have a quick look at the changed add_child
s to confirm.
Let's merge and see if we spot anything unexpected. |
Thanks! |
Fixes #17573
EDIT: Fixes #54177
node_hrcr
was a hack used to forcelegible_unique_name
globally in the editor. This resulted in internal nodes having different name in editor than in game, which is unexpected (see the closed issue).I removed this hack and instead the editor will now explicitly use the
legible_unique_name
argument wherever necessary. (I might've missed some places though)