-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Properly validate godot_project_name_string
for Android special chars
#54255
Android: Properly validate godot_project_name_string
for Android special chars
#54255
Conversation
So this needs more work, there's actually a full table of characters that need to be escaped but not using standard XML escapes... :| |
d58dc32
to
9204a3a
Compare
godot_project_name_string
godot_project_name_string
for Android special chars
This now does the full escaping magic, aside from handling Tested with:
Generates:
Also to note, I used |
I just tested to be sure, using e.g. |
Cherry-picked for 3.4. |
Fixes #52659.
This
true
enabledp_escape_quotes
inxml_escape
:godot/core/string/ustring.cpp
Lines 3876 to 3884 in f2cf52e
And apparently that caused issues.That's not it, see #54255 (comment).
It was added like this originally by @amanj120 in #42185 as part of implementing Android App Bundle support.