-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VoxelGI info label being cut off #54266
Conversation
That's very wide, it will probably cause issues for users with low resolution monitors. I'm not sure why there's so much information encoded horizontally here but this needs to be redesigned. |
We could change the VoxelGI label to only display the VRAM size. It's the main relevant information; the actual probe resolution isn't so important. |
Why does it need to be displayed on the button itself though, and not in a tooltip? |
Do you mean we should display the resolution and VRAM size in the Bake button's tooltip? That sounds like a reasonable solution to me. It's less discoverable this way, but it's secondary information for most people anyway. |
Yeah I think so - unless that's really information that users need to see all the time, but I don't think it is? If you get the information on hover you can still use it to decide if you want to actually press the button given these metrics (as I guess the point is to let users estimate how long it might take?). |
The label(resolution and VRAM size) depending on the estimated performance level gets colored success_color, warning_color or error_color. |
I think the point of the VRAM size display is more about run-time performance than bake times. VoxelGI bake times are pretty fast already – it's rare for them to go beyond a minute on a large scene. In comparison, a CPU lightmapper can take hours on the same scene. |
I don't think removing clipping is a good solution here, I suggest moving this information to a tooltip as discussed above. |
Fixes #53529.
Though it seems like a regression from #35891, it looks like it was just revealed in that commit.
The bug seems to be VoxelGI specific because it couldn't be reproduced on increasing Mesh3DInstance's Mesh button label.
Before fix:
Bugged.
[Hardcoded longer text to test] - Works as expected.
After fix:
Fixed.
[Hardcoded longer text to test] - Works as expected.