Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VoxelGI info label being cut off #54266

Closed
wants to merge 1 commit into from

Conversation

Anutrix
Copy link
Contributor

@Anutrix Anutrix commented Oct 26, 2021

Fixes #53529.

Though it seems like a regression from #35891, it looks like it was just revealed in that commit.
The bug seems to be VoxelGI specific because it couldn't be reproduced on increasing Mesh3DInstance's Mesh button label.

Before fix:
Screenshot 2021-10-26 194906
Bugged.

Screenshot 2021-10-26 194841
[Hardcoded longer text to test] - Works as expected.

After fix:
Screenshot 2021-10-26 195029
Fixed.

Screenshot 2021-10-26 195018
[Hardcoded longer text to test] - Works as expected.

@akien-mga
Copy link
Member

That's very wide, it will probably cause issues for users with low resolution monitors. I'm not sure why there's so much information encoded horizontally here but this needs to be redesigned.

@Calinou
Copy link
Member

Calinou commented Oct 26, 2021

We could change the VoxelGI label to only display the VRAM size. It's the main relevant information; the actual probe resolution isn't so important.

@akien-mga
Copy link
Member

Why does it need to be displayed on the button itself though, and not in a tooltip?

@Calinou
Copy link
Member

Calinou commented Oct 26, 2021

Why does it need to be displayed on the button itself though, and not in a tooltip?

Do you mean we should display the resolution and VRAM size in the Bake button's tooltip? That sounds like a reasonable solution to me. It's less discoverable this way, but it's secondary information for most people anyway.

@akien-mga
Copy link
Member

Yeah I think so - unless that's really information that users need to see all the time, but I don't think it is? If you get the information on hover you can still use it to decide if you want to actually press the button given these metrics (as I guess the point is to let users estimate how long it might take?).

@Anutrix
Copy link
Contributor Author

Anutrix commented Oct 26, 2021

The label(resolution and VRAM size) depending on the estimated performance level gets colored success_color, warning_color or error_color.
This gets lost in tooltip I guess. I don't recall seeing any colored tooltips used in the editor assuming individual tooltips support it.

@Calinou
Copy link
Member

Calinou commented Oct 26, 2021

(as I guess the point is to let users estimate how long it might take?).

I think the point of the VRAM size display is more about run-time performance than bake times. VoxelGI bake times are pretty fast already – it's rare for them to go beyond a minute on a large scene. In comparison, a CPU lightmapper can take hours on the same scene.

@akien-mga
Copy link
Member

I don't think removing clipping is a good solution here, I suggest moving this information to a tooltip as discussed above.

@akien-mga akien-mga closed this Dec 2, 2021
@Anutrix Anutrix deleted the voxelgi-info-label-fix branch July 26, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VoxelGI information label is cut off
3 participants