Fix hardcoded raycast distance in viewport object picking #54369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
having the raycast distance hardcoded to `10000` caused input events to not be registered in very large 3D scenes. This resolves the issue by using the cameras far distance instead. Creating the more predictable behavior of if an object is visible, it will be picked by the viewport. resolves: godotengine#49735
S0yKaf
changed the title
S0yKaf
changed the title
|
I also have a version of this ready for |
aaronfranke
approved these changes
Oct 29, 2021
akien-mga
added
cherrypick:3.x
JFonS
approved these changes
Nov 1, 2021
pouleyKetchoupp
approved these changes
Nov 1, 2021
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
happy to help! |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix hardcoded raycast distance in viewport object picking
having the raycast distance hardcoded to
10000caused input events to not be registered in very large 3D scenes.This resolves the issue by using the cameras far distance instead. Creating the more predictable behavior of "if an object is visible, it will be picked by the viewport."
More info about the issue can be found in #49735
Closes #49735