-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster editor line drawing - Path2D and draw_line #54377
Conversation
Changes the Path2D drawing to use POLYLINE instead of thick lines. Add a path to translate thick lines (that are not using anti-aliasing) to draw as polygons instead. This should be faster because polygons can be batched.
Just to note, got some further testing of the line drawing side of this in #54826. When trying that test project:
If anyone reports the latter as a problem, we can put in a check in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved in today's PR meeting. We should investigate a port to Godot 4. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved in PR review meeting.
Thanks! |
This is not editor only, right? Eager to test this as we use custom path2Ds extensively. |
This works outside the editor too. |
Changes the Path2D drawing to use POLYLINE instead of thick lines.
Add a path to translate thick lines (that are not using anti-aliasing) to draw as polygons instead. This should be faster because polygons can be batched.
Fixes #38543
May fix #52703
Notes
Before:
After: