Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use application name for pulseaudio device #54654

Merged
merged 1 commit into from
Nov 7, 2021
Merged

Use application name for pulseaudio device #54654

merged 1 commit into from
Nov 7, 2021

Conversation

nathanfranke
Copy link
Contributor

@nathanfranke nathanfranke commented Nov 6, 2021 •
edited
Loading

This has two benefits:

  • Use can differentiate between each one and adjust volumes accordingly.
  • Volume will save independently so it will remember the volumes for each one.

Before:
image
After:
image

@nathanfranke nathanfranke requested a review from a team as a code owner November 6, 2021 04:52
@akien-mga akien-mga added this to the 4.0 milestone Nov 6, 2021
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 6, 2021
@akien-mga akien-mga merged commit 6566363 into godotengine:master Nov 7, 2021
@akien-mga
Copy link
Member

Thanks!

@nathanfranke nathanfranke deleted the pulseaudio-fix branch November 7, 2021 01:49
@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 15, 2021
@lawnjelly lawnjelly mentioned this pull request Jul 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire left review comments

@Calinou Calinou Calinou left review comments

@bruvzg bruvzg bruvzg left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:linuxbsd topic:audio topic:porting
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nathanfranke @akien-mga @fire @Calinou @bruvzg