Expose the "restart on exit" OS functionality #54738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
expose-os-restart-on-exit
branch
from
33d4e59
to
8fc8116
Compare
reduz
approved these changes
Jul 31, 2022
|
Needs rebase |
Calinou
force-pushed
the
expose-os-restart-on-exit
branch
from
8fc8116
to
1d64e26
Compare
|
Rebased and tested again, it works as expected. I also added a testing project to OP for future reference and example usage. |
|
Needs another rebase after #63624. |
This can be used to restart a project with specific command line arguments applied. This can work in tandem with `OS.get_cmdline_args()` to restart with the same command line arguments as used to originally run the project. Example use cases: - Restart to apply an user setting change that requires a restart to work. - Restart with a Godot command line argument to change the video driver, audio driver, etc.
Calinou
force-pushed
the
expose-os-restart-on-exit
branch
from
1d64e26
to
1b71317
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterversion of #66168.This can be used to restart a project with specific command line arguments applied. This can work in tandem with
OS.get_cmdline_args()to restart with the same command line arguments as used to originally run the project.Example use cases:
This currently only works if the project is not started from the editor. (It can be started from an editor binary via the command-line still.)
I don't know why this happens – help is welcome for troubleshooting this.
This closes godotengine/godot-proposals#3460.
Testing project: test_restart_on_exit.zip
Preview
restart-on-exit.mp4