Use full type validation in Array::append_array
#54940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdemirer
reviewed
Dec 31, 2021
| Variant src_val = p_array._p->array[i]; | ||
| if (src_val.get_type() == _p->typed.type) { | ||
| new_array.write[i] = src_val; | ||
| } else if (Variant::can_convert_strict(src_val.get_type(), _p->typed.type)) { |
There was a problem hiding this comment.
Wouldn't this create an inconsistency:
var int_array: Array[int] = [1, 2, 3]
func _ready():
int_array.append_array([1.23]) # would be allowed
int_array.append(1.23) # still not allowed
int_array[0] = 1.23 # still not allowedThere was a problem hiding this comment.
I personally am in favor of allowing these assignments to do implicit casting. An inconsistency, yes, but the other operations you've listed I would consider a little restrictive.
|
Checked briefly in a PR review meeting and we agreed that fixing these bugs makes sense. @vnen should have a proper look at the implementation before merging (maybe also adding GDScript unit tests to validate the different scenarios?). |
This was referenced Oct 15, 2022
|
Both linked bugs are now fixed, and there has been many changes to GDScript since this PR has been last updated. Closing as superseded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54939
Might fix #52485 or at least a part of it
Lightly tested. Probably needs some test cases added.
I'm not happy with how this currently looks. This was copied and modified from
Array::_assign. Not sure if there's a way to reduce code duplication here without losing performance.