-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draw the filled part of the slider on float EditorSpinSliders #55519
Draw the filled part of the slider on float EditorSpinSliders #55519
Conversation
This makes it more obvious that the slider has a "filled" part on the left, which improves visibility especially in wider inspectors (such as the Project Settings and Editor Settings).
Whoa, I never realized the sliders have a filled part! My poor eyes say THANKS!!! |
That looks pretty cool for ratios definitely. But what about arbitrary float sliders which do not range from 0 to 1? Is the "filled"/"progress" concept still relevant? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only reviewed the photos. The feature improves usability.
Edited:
May want to tune the scale of the contrast of the three portions for OLED screens and etc.
I have the same concern as Akien. It sure makes semantic sense in some situations, but not in others. Maybe it should be an option and we should only enable it for properties that have Edit: Though, I guess the slider itself is already only visible in such cases. Probably good then. |
Well my point is that sometimes the range we specify is not the range of absolute values that something can take, but a generic "wide yet small enough" range for a slider to be a meaningful way to pick a value. For example:
It doesn't make much sense to represent That being said, I'm not sure if it's actually detrimental to UX as opposed to just being superfluous in this case. |
IMO that's probably fine. |
Thanks! |
master
version of #55521.This makes it more obvious that the slider has a "filled" part on the left, which improves visibility especially in wider inspectors (such as the Project Settings and Editor Settings).
Preview