Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix C# get_all_delegates method for generic classes #55564

Merged

Conversation

raulsntos
Copy link
Member

3.x version of #55563

@raulsntos raulsntos requested a review from a team as a code owner December 2, 2021 21:18
@raulsntos raulsntos changed the title Fix get_all_delegates method for generic classes [3.x] Fix C# get_all_delegates method for generic classes Dec 2, 2021
@aaronfranke aaronfranke added this to the 3.5 milestone Dec 2, 2021
@raulsntos raulsntos force-pushed the csharp-delegates-for-generic-class-3.x branch from 368859a to 87eeaca Compare December 2, 2021 21:22
If the class is generic, we must get its generic type definition and use
it to retrieve the delegates.
@raulsntos raulsntos force-pushed the csharp-delegates-for-generic-class-3.x branch from 87eeaca to 613751a Compare December 4, 2021 01:56
@akien-mga akien-mga merged commit c42e9bd into godotengine:3.x Dec 4, 2021
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the csharp-delegates-for-generic-class-3.x branch December 4, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants