Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaking environment RIDs in GLES2 #55701

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

lawnjelly
Copy link
Member

This PR adds the code necessary to correctly free environments in GLES2, which was previously missing causing them to leak.

Notes

  • This was showing up in the tracked_handles build ([3.x] Add option to use handles to RID #54907)
  • On tracking this down, it turned out although the client code was correctly calling free, the freeing code in RasterizerScene had been forgotten
  • These will have been leaking during the editor and particularly during gameplay with multiple levels

This PR adds the code necessary to correctly free environments in GLES2, which was previously missing causing them to leak.
@lawnjelly lawnjelly requested a review from a team as a code owner December 7, 2021 18:49
@Chaosus Chaosus added this to the 3.5 milestone Dec 7, 2021
@akien-mga akien-mga merged commit 7ac92d2 into godotengine:3.x Dec 7, 2021
@akien-mga
Copy link
Member

Thanks!

@lawnjelly lawnjelly deleted the fix_gles2_env_leak branch December 8, 2021 07:31
@akien-mga
Copy link
Member

Cherry-picked for 3.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants