Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Text Server] Fix re-shaping of substrings, improve font oversampling. #55905

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 13, 2021

Fixes #55904, fixes part of #55807

  • Fixes substring reshaping.
  • Removes excessive glyph coordinate rounding, fractional size is reasonable for fractional oversampling.
  • Improves oversampling by taking into account real and requested font size difference to adjust scaling.

Left-to-right:

  • Normal font with oversampling
  • MSDF font
Screen.Recording.2021-12-15.at.11.53.07.mov

#55807 test project:

Screen.Recording.2021-12-15.at.12.04.39.mov

@bruvzg bruvzg added this to the 4.0 milestone Dec 13, 2021
@bruvzg bruvzg changed the title [Text Server] Fix re-shaping of substrings. [Text Server] Fix re-shaping of substrings, improve font oversampling. Dec 14, 2021
@bruvzg bruvzg marked this pull request as ready for review December 15, 2021 10:06
@bruvzg bruvzg requested a review from a team as a code owner December 15, 2021 10:06
@akien-mga akien-mga merged commit 859549e into godotengine:master Dec 15, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text wrapping is broken if the window is resized when using the canvas_items stretch mode
2 participants