[Windows, 4.0] Detect new Windows Terminal and disable unsupported set_console_visible code.

[bruvzg]

• Improves [Windows, 4.0] Open a new console window for the editor instances. #55924, new terminal will be opened only when using new Windows Terminal.
• Disables unsupported set_console_visible / Toggle System Console when using new Windows Terminal.

Tested on Windows 11 21H1(22000.348) with:

• Windows Console Host (Old terminal)
• ConEmu 210912
• Windows Terminal 1.11.2921.0

Bugsquad edit: Closes #55971.

[mhilbrunner]

So if I understand it right, this is mostly a heuristic: ENABLE_VIRTUAL_TERMINAL_PROCESSING was added for the Windows Terminal in the Windows 10 Anniversary update, and isn't enabled by default in the legacy console, but is enabled by default in Windows Terminal.

Thus we can check if it is enabled and assume we're likely running in a Windows Terminal. In theory, we could also be running in another console that has this turned on manually.

This looks acceptable to me, but maybe we could have a comment explaining/documenting this? Maybe we also want to link to the original Github issue for future readers. (#54076)

That would

1. explain this/make it more readable
2. ensure we remember to remove it if this is fixed/not revelant anymore upstream

[akien-mga]

Adding a short comment sounds good yeah. The issue can be referenced as GH-54076 in text, that's how I do it usually (it's easy enough to get to the URL from there, without having to hardcode all kinds of github.com all over the place).

[akien-mga]

That being said, we might prefer to wait for the approach taken in #55987 and thus only merge this workaround for 3.4?

[akien-mga]

I'll merge as is for now as I want to cherry-pick #55967 for 3.4.1, and it's good to keep things consistent. Comments can be added later, or won't be needed if we go with the approach in #55987 and thus undo this workaround.

[akien-mga]

Thanks!