-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] OSX: Add signing of directory structure when exporting for OSX #56250
[3.x] OSX: Add signing of directory structure when exporting for OSX #56250
Conversation
Please amend the commit to use the original commit message, at least as the first line. |
This is done :) |
Why some checks have been cancel ? |
I don't know. I re-ran them manually; let's see if they complete this time. |
Still fails with cancel :s |
There's a GitHub Actions bug on this PR, when builds are queued for too long (which happens with macOS jobs as they're more limited so we run out of allocated resources fast) it cancels them. I think it's because this was a first time contributor PR with manual approval, there must be a buggy codepath there. I've tried to restart them 4 times but there's always an hour or more of waiting time for a macOS build so they get cancelled. Maybe try to rebase and force push. Now that you have a merged PR it should no longer require approval and might side step that bug. Though there seems to be another CI bug on the 3.x branch right now so maybe wait a bit. |
71cb8d3
to
c58391c
Compare
… OSX. Add exporting of folder structure in PlugIns when exporting for OSX.
Thanks! |
Port of #56047