Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GraphEdit's minimap doesn't show using minimap_enabled #57239

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Fix GraphEdit's minimap doesn't show using minimap_enabled #57239

merged 1 commit into from
Apr 11, 2022

Conversation

emcguirk
Copy link
Contributor

@emcguirk emcguirk commented Jan 26, 2022 •
edited by Chaosus
Loading

Fixes the issue where the Button does not restore the minimap after toggling off with GraphEdit

animation

Bugsquad edit:

@emcguirk emcguirk requested a review from a team as a code owner January 26, 2022 02:41
@YeldhamDev YeldhamDev added this to the 4.0 milestone Jan 26, 2022
@Chaosus Chaosus changed the title Closes godotengine/godot #53831 Fix GraphEdit's minimap doesn't show using minimap_enabled Jan 26, 2022
@Chaosus
Copy link
Member

Chaosus commented Jan 26, 2022

Please amend the commit name to use a correct PR name: Closes godotengine/godot godotengine#53831 -> Fix GraphEdit's minimap doesn't show using minimap_enabled

KoBeWi
KoBeWi approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please amend the commit as commented before.

@akien-mga
Copy link
Member

I updated the message myself so we can merge it.

@akien-mga akien-mga added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.4 labels Apr 11, 2022
@akien-mga akien-mga merged commit 2fd5f20 into godotengine:master Apr 11, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 13, 2022
@akien-mga
Copy link
Member

Cherry-picked for 3.4.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Sometimes GraphEdit minimap doesn't show using minimap_enabled
5 participants
@emcguirk @Chaosus @akien-mga @KoBeWi @YeldhamDev