Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Center View button to 2D editor #57252

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jan 26, 2022

image
Does the same as pressing F shortcut.

Helps #47628

@KoBeWi KoBeWi added enhancement topic:editor usability cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:2d labels Jan 26, 2022
@KoBeWi KoBeWi added this to the 4.0 milestone Jan 26, 2022
@akien-mga akien-mga requested a review from a team January 26, 2022 14:50
@YeldhamDev
Copy link
Member

Too detailed for its size. It would be better for the icon to be the same as the "Move Mode" (shown in the screenshot), but with the arrows reversed.

@KoBeWi
Copy link
Member Author

KoBeWi commented Jan 26, 2022

It's the same as in tile editor though.

@arkology

This comment has been minimized.

@YeldhamDev
Copy link
Member

It's the same as in tile editor though.

Then it should likely be changed there too.

@KoBeWi
Copy link
Member Author

KoBeWi commented Jan 26, 2022

CC @groud

@groud
Copy link
Member

groud commented Feb 1, 2022

Hmm, I am not against it, but well, it's only useful when you disable the constrained scrolling area IMO.
And, TBH, I still think constraining the working area is better.

To solve the initial problem, we could maybe extend the constrained area to 2 or 3 screen size something like that. That could be a good in-between solution I guess.

@YuriSizov YuriSizov modified the milestones: 4.0, 4.x Aug 16, 2022
@YuriSizov YuriSizov modified the milestones: 4.x, 4.1 May 31, 2023
@YuriSizov
Copy link
Contributor

Can you rebase it? I would be in favor of merging this. While in here Gilles says it's only useful when we remove constraints, in #47628 he makes a valid point that people may not find it easy to find the shortcut for this action. So IMO the button is justified regardless.

@YuriSizov YuriSizov merged commit 506eaf8 into godotengine:master May 31, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@KoBeWi KoBeWi deleted the clickable_F branch May 31, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:editor topic:2d usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants