Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default physics material and physics material override for root CSGShape #59386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gaudecker
Copy link
Contributor

@gaudecker gaudecker commented Mar 21, 2022

Adds a default physics material, same that StaticBody3D has, and adds a new property to override the default physics material.

Fixes #36893

Small demo project: csg-physics-material-demo.zip

@gaudecker gaudecker requested a review from a team as a code owner March 21, 2022 13:01
@gaudecker gaudecker force-pushed the csgshape-physics-material branch 2 times, most recently from c6a0ae4 to 41a5dd6 Compare March 21, 2022 13:16
@Calinou Calinou added this to the 4.0 milestone Mar 21, 2022
@YuriSizov
Copy link
Contributor

We've discussed this in a PR meeting, and decided it would be good to open a proposal to discuss this further. The existing issue can be converted to one, but it'd be better to open a new proposal and supersede the issue. This may be adding too much to the CSG systems which were mainly created for blocking and prototyping.

@Calinou
Copy link
Member

Calinou commented Aug 28, 2023

We've discussed this in a PR meeting, and decided it would be good to open a proposal to discuss this further. The existing issue can be converted to one, but it'd be better to open a new proposal and supersede the issue. This may be adding too much to the CSG systems which were mainly created for blocking and prototyping.

A proposal was opened: godotengine/godot-proposals#7568

@aaronfranke
Copy link
Member

See also this proposal: godotengine/godot-proposals#7401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add physics material field for CSG objects CSGShape doesn't have physics material
4 participants