-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Fix flickering issues with low processor mode on Android #59606
Conversation
c9160a6
to
f921b62
Compare
@akien-mga Given we're forking two files, can we disable the static checks on them? |
You can add Make sure to identify the downstream changes clearly in those files so that we know what is Godot specific. |
…ine/godot#59606, although I did it differently.
f921b62
to
548be06
Compare
@akien-mga Done! |
f1fbe34
to
6cc41ac
Compare
32d72c7
to
4c7b889
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to say beyond what I've commented in the PR for 4.0.
4c7b889
to
8ca32d1
Compare
Thanks! |
As pointed out by @Relintai in #55604 (comment), the cause of the flickers when enabling low processor mode is that the framebuffers are swapped automatically even when nothing is rendered.
To resolve the issue, I forked
GLSurfaceView
so that the Godot Android logic can specify when the framebuffers should be swapped.Fixes #19304