Fix AnimatedSprite
doesn't emit animation_finished
when changing playback direction
#61085
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61078
The
is_over
here is preventing the signal from being triggered.godot/scene/2d/animated_sprite_2d.cpp
Lines 189 to 192 in c41f62c
It will be reset to
false
in_reset_timeout()
. When callingplay()
inanimation_finished
,set_playing()
will be called, but it will return immediately as theplaying
state is not changed. So theis_over
is stilltrue
.godot/scene/2d/animated_sprite_2d.cpp
Lines 368 to 375 in c41f62c
I think it makes sense to always reset
is_over
tofalse
inplay()
.