Fix ParticlesMaterial collision friction/bounce at low velocity #61245
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2022
- Scale down bounce if the particle velocity is low (relative to the bounce multiplier chosen). This prevents particles from bouncing forever at low amplitude, which looks odd. - Don't allow the computed friction multiplier to go above 1.0. This prevents particles from spazzing out after stopping. Particles that used to jitter all over the place now look very smooth, even when Fixed Fps is decreased to 20 (as long as interpolation is enabled).
Calinou
force-pushed
the
particlesmaterial-fix-collision-friction-bounce
branch
from
21a8ca8
to
6139a46
Compare
Calinou
changed the title
6 tasks
|
Does not look like a correct relationship (bounce multiplier is a ratio and velocity is an absolute value), i wonder if a separate threshold should be added for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Particles that used to jitter all over the place now look very smooth, even when Fixed Fps is decreased to 20 (as long as interpolation is enabled).
I tested this PR on the MRPs linked in #57249 and #57197.
This closes #57249.