Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Add readable export errors. #61624

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 2, 2022

Adds readable errors to the export dialog and log, instead of the misleading missing/corrupted templates or configuration error error that's currently displayed.

  • Add custom error popup, with scrollable RTL and color coded warnings and errors, to improve readability.
  • Make sure all export plugins use the same error reporting interface (currently there's a mess of random prints, and multiple "warning" and "I/O error" dialogs).
  • Add missing error messages.

Before:
Screenshot 2022-06-02 at 11 18 39

After ("Export All", for single export it's displayed only if there's something to show):
Screenshot 2022-06-03 at 14 10 32

Fixes #61392

@Zireael07
Copy link
Contributor

Can we expect something similar for master/4.x?

@bruvzg
Copy link
Member Author

bruvzg commented Jun 2, 2022

Can we expect something similar for master/4.x?

Definitely, I'll port it to master as soon as 3.x version is done.

@bruvzg bruvzg force-pushed the export_errors branch 5 times, most recently from 3ad2540 to 75e0f2f Compare June 3, 2022 17:29
@bruvzg bruvzg changed the title [WIP, 3.x] Add readable export errors. [3.x] Add readable export errors. Jun 3, 2022
@bruvzg bruvzg marked this pull request as ready for review June 6, 2022 06:35
@bruvzg bruvzg requested review from a team as code owners June 6, 2022 06:35
@akien-mga akien-mga merged commit 49205cc into godotengine:3.x Jun 8, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga removed this from the 3.x milestone Jun 8, 2022
@akien-mga akien-mga added this to the 3.5 milestone Jun 8, 2022
@bruvzg bruvzg deleted the export_errors branch June 8, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants