Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve description of move_to_trash() #61945

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Improve description of move_to_trash() #61945

merged 1 commit into from
Jun 13, 2022

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jun 11, 2022

@KoBeWi KoBeWi added enhancement topic:core documentation cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Jun 11, 2022
@KoBeWi KoBeWi added this to the 4.0 milestone Jun 11, 2022
@KoBeWi KoBeWi requested a review from a team as a code owner June 11, 2022 21:06
timothyqiu
timothyqiu reviewed Jun 12, 2022
View reviewed changes
doc/classes/OS.xml Outdated Show resolved Hide resolved
@KoBeWi KoBeWi force-pushed the making_move_to_trash_less_trash branch from b52aab8 to 1c90b06 Compare June 13, 2022 10:58
@akien-mga akien-mga merged commit 1f152b3 into godotengine:master Jun 13, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jun 13, 2022
@KoBeWi KoBeWi deleted the making_move_to_trash_less_trash branch June 13, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothyqiu timothyqiu timothyqiu left review comments

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
documentation enhancement topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

OS.move_to_trash() lacks critical information. OS.move_to_trash() not functioning or poorly documented
4 participants
@KoBeWi @akien-mga @timothyqiu @bruvzg