Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Add global_translation and global_rotation to Spatial #63058

Merged
merged 1 commit into from
Jul 18, 2022
Merged

[3.x] Add global_translation and global_rotation to Spatial #63058

merged 1 commit into from
Jul 18, 2022

Conversation

AaronRecord
Copy link
Contributor

Cherry-picks 8b16a41

@AaronRecord AaronRecord changed the base branch from master to 3.x July 16, 2022 01:09
@AaronRecord AaronRecord changed the title Backport-global-position-rotation Backport global_position and global_rotation to Spatial Jul 16, 2022
@AaronRecord AaronRecord marked this pull request as ready for review July 16, 2022 01:11
@AaronRecord AaronRecord requested review from a team as code owners July 16, 2022 01:11
@AaronRecord AaronRecord changed the title Backport global_position and global_rotation to Spatial [3.x] Add global_position and global_rotation to Spatial Jul 16, 2022
@AaronRecord AaronRecord marked this pull request as draft July 16, 2022 01:19
@AaronRecord AaronRecord force-pushed the backport-global-position-rotation branch 2 times, most recently from 0a6e4de to 64673eb Compare July 16, 2022 01:38
@AaronRecord AaronRecord marked this pull request as ready for review July 16, 2022 01:38
@foxydevloper
Copy link
Contributor

It should be global_translation over global_position, as the position property is translation in 3.x

@AaronRecord AaronRecord force-pushed the backport-global-position-rotation branch 4 times, most recently from a7b3a62 to c48a34f Compare July 16, 2022 02:13
@AaronRecord AaronRecord changed the title [3.x] Add global_position and global_rotation to Spatial [3.x] Add global_translation and global_rotation to Spatial Jul 16, 2022
@AaronRecord
Copy link
Contributor Author

It should be global_translation over global_position, as the position property is translation in 3.x

Okay should be all good now

@AaronRecord AaronRecord force-pushed the backport-global-position-rotation branch from c48a34f to 5238740 Compare July 16, 2022 03:39
@akien-mga akien-mga added this to the 3.x milestone Jul 16, 2022
akien-mga
akien-mga approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's purely new code so should be safe to merge now for 3.5.

@akien-mga akien-mga modified the milestones: 3.x, 3.5 Jul 18, 2022
@akien-mga akien-mga merged commit 5aa22a2 into godotengine:3.x Jul 18, 2022
@akien-mga
Copy link
Member

Thanks!

@AaronRecord AaronRecord deleted the backport-global-position-rotation branch July 19, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:3d
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@AaronRecord @foxydevloper @akien-mga