Clarify create_from_image() usage #63127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_from_image()
should be always used to create ImageTexture and can no longer be used on existing ImageTexture. I don't know the internals exactly, but judging from the old descriptions there is no point in reusing ImageTexture ascreate_from_image()
is the most expensive part of it anyway.Resolves #63025
Closes #63131
EDIT:
Turns out there is some use case-case for updating ImageTexture, which is when you have multiple copies of it and want to update all of them, so I updated the PR to expose
set_image()
.