Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate errors for getters of untyped variables returning nothing (superseded by #79363) #63541

Closed
wants to merge 10,000 commits into from

Conversation

garychia
Copy link
Contributor

Fixes #63393
Errors are generated for getter functions where not all code paths return a value.
image

@garychia garychia requested a review from a team as a code owner July 27, 2022 14:40
@garychia garychia changed the title Generate Errors for Getters of Untyped Variables Returning Nothing Generate errors for getters of untyped variables returning nothing Jul 27, 2022
@akien-mga akien-mga added this to the 4.0 milestone Jul 27, 2022
@akien-mga akien-mga modified the milestones: 4.0, 4.1 Feb 13, 2023
@adamscott adamscott modified the milestones: 4.1, 4.2 Jun 17, 2023
@adamscott
Copy link
Member

As the PR needs a rebase and the release is close, I moved the milestone to 4.2.
I put it, though, in the list of PRs that needs a review from the team, not to forget it.

RandomShaper and others added 19 commits June 23, 2023 16:40
…xtension

Fix text_server_adv compiling as a GDExtension
Disable doc cache temporarily for pre-RC stabilization
…arly-onset-layout-dementia

Handle contextual editors gracefully when restoring layout
Explicitly clear the separate specular buffer when the background mode is canvas and screen space effects (and thus a separate specular buffer) are used.
…oving-child-during-focus-exit-

Fix crash when removing child during focus exit.
Reset filter/repeat state of textures in GL Compatibility renderer when render target is cleared
When trying to export a C# project, this displays an error message after
creating a export preset for an unsupported platform.

Support for these platforms is planned for a future release.
This is consistent with the script creation dialog.
…e-web-csharp-error

Display a message about missing C# support on Android/iOS/Web platforms
…x-paste-value-not-updating-element-in-dictionaries/array

Revert "Fix paste value not updated in dictionaries/arrays"
…atch

Varying mismatch causing shaders to fail.
@garychia garychia requested review from a team as code owners July 11, 2023 16:29
@garychia
Copy link
Contributor Author

I'll close this pull request and open a new one to work on the lastest codebase.

@garychia garychia closed this Jul 11, 2023
@garychia garychia deleted the GetterNoReturnError branch July 11, 2023 17:02
@aaronfranke aaronfranke removed request for a team July 11, 2023 17:45
@dalexeev dalexeev removed this from the 4.2 milestone Jul 12, 2023
@dalexeev dalexeev changed the title Generate errors for getters of untyped variables returning nothing Generate errors for getters of untyped variables returning nothing (superseded by #79363) Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GDScript 2.0: getter of untyped variables can return nothing on some code paths