Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding options in theme for fg/bgcolor tags in RichTextLabel #63590

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Add padding options in theme for fg/bgcolor tags in RichTextLabel #63590

merged 1 commit into from
Oct 31, 2022

Conversation

golfinq
Copy link
Contributor

@golfinq golfinq commented Jul 28, 2022

Addresses godotengine/godot-proposals#4808 by adding two new theme constants text_highlight_h_padding and text_highlight_v_padding which adds padding equally around the boxes the RichTextLabel tags fgcolor and bgcolor draw.

Example:
padding_override

@golfinq golfinq requested review from a team as code owners July 28, 2022 19:30
@akien-mga akien-mga added this to the 4.0 milestone Jul 28, 2022
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. It's a simple change.

@akien-mga akien-mga requested a review from bruvzg October 31, 2022 09:50
@akien-mga akien-mga merged commit b6cbea5 into godotengine:master Oct 31, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants