[3.x] Add error messages and docs to explain allowed transitions in NetworkedMultiplayerCustom.set_connection_status() #63628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
changed the title
dsnopek
changed the title
…edMultiplayerCustom.set_connection_status()
dsnopek
force-pushed
the
multiplayer-custom-docs-3.x
branch
from
6bb6c18
to
738e76b
Compare
Faless
approved these changes
Jul 29, 2022
|
Thanks! |
jarommadsen
added a commit
to jarommadsen/godot
that referenced
this pull request
Jul 29, 2022
…n to guide usage Some suggestions based on the new `NetworkedMultiplayerCustom` class introduced in godotengine#63163. @dsnopek I've made some suggestions to the docs based on what would have helped me through my first time. This in conjunction with godotengine#63628 and your new additions in godotengine#63637 should help new users understand what's going on without having to dig through the source code. I'd also like some help improving the `deliver_packet` method docs since I haven't gotten around to really digging through how that gets propagated. I assume the `from_peer_id` is meant to be the unique network id the sender of that packet was initialized with? And am I correct in assuming the `target_id`/`target_peer` is what it uses to deliver it the right place locally? I think some further documentation here would be helpful to know how to use `set_target_peer` in conjunction with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #63163
A user tried using the new class, and commented there that some error messages and documentation about which transitions are allowed in
NetworkedMultiplayerCustom.set_connection_status()would have been helpful.This PR adds those!