Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] File: Re-add support to skip CR (\r) in File::get_as_text #63745

Merged
merged 1 commit into from
Aug 1, 2022
Merged

[3.x] File: Re-add support to skip CR (\r) in File::get_as_text #63745

merged 1 commit into from
Aug 1, 2022

Commits on Jul 31, 2022

  1. File: Re-add support to skip CR (\r) in File::get_as_text 

    This was removed in godotengine#63481, and we confirmed that it's better like this,
but we add back the possibility to strip CR as an option, to optionally
restore the previous behavior.

For performance this is done directly in `String::parse_utf8`.

Also fixes Android `FileAccess::get_line()` as this one _should_ strip CR.

Supersedes godotengine#63717.

(cherry picked from commit 1418f97)
    @akien-mga
    akien-mga committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    751b16a View commit details
    Browse the repository at this point in the history