Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document editor settings in the class reference #63870

Merged
merged 1 commit into from
Aug 6, 2022

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 3, 2022

Follow-up to #48548.

Note that despite fully filling in the XML, this doesn't actually document all editor settings due to some of them being registered too late (see #48548 (comment)). This will require a separate PR to move those settings' registration to happen early enough.

@Calinou Calinou requested a review from a team as a code owner August 3, 2022 10:41
@Calinou Calinou added this to the 4.0 milestone Aug 3, 2022
@akien-mga
Copy link
Member

Needs a rebase.

Could also use more review from @godotengine/documentation, I just had a cursory look. But I prefer to merge early and possibly improve later than to let it gather conflicts too long.

@akien-mga akien-mga merged commit 3eb0cad into godotengine:master Aug 6, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

I cherry-picked the PR that adds support this (in #64838), so this could be backported too (needs to be done manually as the set of settings is not exactly the same).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants