Include the Window-transform into Viewport::get_final_transform #66692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Oct 4, 2022
Sauermann
force-pushed
the
fix-window-final-transform
branch
from
9504a70
to
9c2c5cc
Compare
Sauermann
force-pushed
the
fix-window-final-transform
branch
from
9c2c5cc
to
83fa14a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #66690
don't merge at the same time as #67791
This patch includes the window-transform
Viewport::_get_input_pre_xform()into the calculation ofViewport::get_final_transform()and makes according adjustments in all relevant code locations.Special treatment is necessary in
Viewport::get_camera_coords(), since here the window-transform must not be included.