GDScript: Improve error messages for invalid indexing #66948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These errors are very common when using an invalid property name or calling on an object of the wrong type, and the previous message was a bit cryptic for users.
akien-mga
force-pushed
the
gdscript-improve-indexing-error
branch
from
2b069b6
to
6aa9fb8
Compare
|
It's not perfect as is as the same code is used when indexing arrays with I might rework it to be a bit more clever though, it's a bit annoying that indexing basically covers property/member access, dictionary keys (which can be accessed like properties) and array indexing. |
|
Marking as draft as I'm not actively working on it now. I'd welcome anyone who wants to take it over and make sure that it gives a meaningful message in all cases. |
|
Superseded by #82639. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These errors are very common when using an invalid property name or calling on an object of the wrong type, and the previous message was a bit cryptic for users.
Before
After
(was missing quotes in this last one, fixed afterwards)