Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the conditions for firing 'No such file or directory' error on Linux move_to_trash #67158

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Fix the conditions for firing 'No such file or directory' error on Linux move_to_trash #67158

merged 1 commit into from
Jun 19, 2023

Conversation

amoriqbal
Copy link
Contributor

Fixes #67157

@amoriqbal amoriqbal requested a review from a team as a code owner October 9, 2022 21:37
@Calinou Calinou added this to the 4.0 milestone Oct 9, 2022
@amoriqbal
Copy link
Contributor Author

I have reproduced the issue and checked the bug-fix in both KDE (kde neon os) and GNOME (ubuntu) environments.

@amoriqbal amoriqbal changed the title Changed the conditions for firing 'No such file or directory' error Fixed the conditions for firing 'No such file or directory' error Oct 11, 2022
@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 12, 2023
@akien-mga akien-mga changed the title Fixed the conditions for firing 'No such file or directory' error Fix the conditions for firing 'No such file or directory' error on Linux move_to_trash Jun 19, 2023
@akien-mga akien-mga merged commit 01e84b1 into godotengine:master Jun 19, 2023
@akien-mga
Copy link
Member

Thanks!

@starccy
Copy link

starccy commented Jul 10, 2023

Hi @amoriqbal, sorry to bother you in a closed PR. But I found that in 43264bf to change the condition from err_code == 2 to 1 could cause other problems.

May you have a look at #79108

It seems that not only the 'No such file or directory' error use this error code, but also some else use it too, which can lead to the flow returning early instead of using fallback methods, so the files delete failed.

@akien-mga akien-mga mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:linuxbsd topic:porting
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

OS.move_to_trash() gives wrong error message for non-existent file.
5 participants
@amoriqbal @akien-mga @starccy @Calinou @YuriSizov