Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Packed*Array over Vector<T> in TypedArray #67226

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Use Packed*Array over Vector<T> in TypedArray #67226

merged 1 commit into from
Feb 7, 2024

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Oct 10, 2022

Same as #67220 but for typed_array.h.

@Mickeon Mickeon requested a review from a team as a code owner October 10, 2022 23:27
@Chaosus Chaosus added this to the 4.0 milestone Oct 14, 2022
@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 10, 2023
@YuriSizov YuriSizov modified the milestones: 4.1, 4.2 Jun 14, 2023
@Mickeon
Copy link
Contributor Author

Mickeon commented Sep 6, 2023

Rebased after conflict.

@AThousandShips AThousandShips modified the milestones: 4.2, 4.3 Oct 26, 2023
adamscott
adamscott approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me!

@akien-mga
Copy link
Member

Could use a rebase for good measure.

@Mickeon
Copy link
Contributor Author

Mickeon commented Feb 6, 2024

Rebased to master

@akien-mga akien-mga merged commit dd2699b into godotengine:master Feb 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Mickeon Mickeon deleted the typed-packing branch February 7, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle topic:core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@Mickeon @akien-mga @adamscott @Chaosus @YuriSizov @AThousandShips