-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fallback to vkCreateRenderPass #67227
Added fallback to vkCreateRenderPass #67227
Conversation
f8b80b2
to
39b5a8d
Compare
@akien-mga For Vulkan 1.2 and newer this is now core functionality and should be supported as such. The only thing I wonder about is seeing this used to be an extension and we are using it through the extension for backwards compatibility, whether it now being core means they are phasing that out. We may need to specifically test for Vulkan 1.2 or newer and just check for the core function or something like that. It's a bit hard to say without having different hardware to test. |
…TENSION_NAME isn't supported
39b5a8d
to
64a78c3
Compare
@clayjohn I think I got all your changes.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I ran master on my old laptop which I thought may reproduce the reported crash but unfortunately the extension was supported and I couldn't reproduce the crash.
Even though
vkCreateRenderPass2KHR
was introduced as an extension in Vulkan 1.0, support doesn't seem to be universal for it.As we only need the updated call for Multiview and VRS, this PR adds a fallback to the old
vkCreateRenderPass
if theVK_KHR_create_renderpass2
extension is not available.Fixes #66685 and fixes #67146