Add STATIC_CALLED_ON_INSTANCE warning #67365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@akien and I discussed this in the PR review meeting this morning. This warns users when they call static functions from objects instead of calling them from the class.
The purpose of this warning is to avoid the silent failure resulting from functions which have become static recently (e.g. #67319).
Now users will have a warning hinting that they may need to change their code.
The following code:
Results in this warning
Once this PR and #67361 are merged, we should be able to move forward with making some other functions static as in #63332