-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings in class ref #68848
Fix warnings in class ref #68848
Conversation
26b8670
to
b5a1f1a
Compare
b5a1f1a
to
8490f51
Compare
Looks good! Could you squash the commits? See PR workflow for instructions. |
8490f51
to
a5e5f1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, haven't tested the make_rst.py
changes though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it locally and the resulting diff for RST files looks correct.
Thanks! |
Fix:
WARNING: Could not lex literal_block as "csharp". Highlighting skipped
(invalid comment character # instead of //)
Fix:
WARNING: undefined label: class_popup_property_popup_window
the referenced member needs to reference the parent class
Fix:
WARNING: undefined label: class_basis_operator_mul_vector3
, ...Operators with the same name didn't create the class ref in the operator description section.
This fix results in:
WARNING: Duplicate explicit target name
Operators can have the same name and return type, which are used to create the ref identifier, resulting in duplicates.
example: class_float with
vector2
andvector2i
both returningvector2
This change will instead include parameter types and not return types in the identifier, but this can break external links to the operator description.
Internal should all be updated by this change. (I hope...)