iOS: Fix memory leak on touch input [3.x] #69200
Merged
+43
−291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2022
tbveralrud
changed the title
|
Just tested this in our game that uses quick tap controls. It indeed resolved the memory leak, and even more importantly, it eliminated the horrible input stutters / frame drops that were making the game unplayable even on new iPhones. Very much looking forward to seeing this merged, great work! |
tbveralrud
force-pushed
the
ios-touch-leak-fix-3.x
branch
from
e4ae262
to
bba1f69
Compare
|
@bruvzg This has been rebased. |
Replaces iOS gesture with touch implementation Fixes godotengine#66422 Remove godot_view_gesture_recognizer It's now unused. Remove input_devices/pointing/ios/touch_delay Unused with removal of gesture. Remove unused methods from interface Implementation made obsolete in prior commit Style conformance
tbveralrud
force-pushed
the
ios-touch-leak-fix-3.x
branch
from
bba1f69
to
28b11a0
Compare
|
...and once more with a squash. |
akien-mga
approved these changes
Feb 16, 2023
|
Thanks! |
|
Good stuff! Thanks all. Maybe the problem was hidden for us since the touch_delay was set to 0.01, but will definitely give it a try on the next RC, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66422 for 3.x branch. A fix for master is at #69201.
Replaces gesture recognizer with touch events directly from the view.
Rationale:
Gesture recognizers retain all touch events until their
stateproperty changes to "cancelled" or "ended."The custom recognizer in the project fails to implement this requirement.
Setting the state to "ended" in the recognizer resolves the leak but introduces runtime assertions in logic that relied on an unending recognizer.
By forwarding the touch events directly from the view to Godot removes the need for a gesture recognizer.
Furthermore, the motivation for delaying touch inputs looks to be resolved too. (See #39624)
This branch removes the delay from touch events, putting iOS on parity with other platforms.
Project setting
input_devices/pointing/ios/touch_delayhas been removed as a consequence.